Skip to content

Sync FIX_REASK Bug Fix #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Sync FIX_REASK Bug Fix #1253

merged 1 commit into from
Apr 7, 2025

Conversation

CalebCourier
Copy link
Collaborator

Summay

  • Add missing kwarg for validation_session_id when SequentialValidatorService.run_validators calls SequentialValidatorService.run_validator_sync when on_fail="fix_reask"
  • Add test to verify change

@CalebCourier CalebCourier requested review from zsimjee and a team April 7, 2025 14:42
@zsimjee zsimjee merged commit 1ac8443 into main Apr 7, 2025
16 checks passed
@zsimjee zsimjee deleted the fix-reask-bug-fix branch April 7, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsimjee zsimjee zsimjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalebCourier @zsimjee