Skip to content

fix telem problem from api and add e2e server test gh action #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

dtam
Copy link
Contributor

@dtam dtam commented Oct 2, 2024

No description provided.

Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mate! Commented a few q's I had

Comment on lines 7 to 9
pull_request:
branches:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's exclude this I think. Runs too often, too many tests. Good to have on push to main though

zsimjee
zsimjee previously approved these changes Oct 2, 2024
@zsimjee zsimjee dismissed stale reviews from AlejandroEsquivel and themself via 3570ecc October 2, 2024 21:59
@zsimjee zsimjee merged commit 7153745 into main Oct 2, 2024
12 checks passed
@zsimjee zsimjee deleted the fix_server_mismatch branch October 2, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants