Skip to content

NLTK Removal #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 21, 2024
Merged

NLTK Removal #1102

merged 24 commits into from
Oct 21, 2024

Conversation

AlejandroEsquivel
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel commented Sep 27, 2024

Updated:

  • Removed nltk in favour of a rule based sentence splitter
  • Ported and modified WordTokenizers.jl sentence splitter, namely to account for more abbreviations, not splitting in between quotations, using custom separator as opposed to new line character which could erroneously split new line characters in original text that aren't the end of a sentence

Removed Packages:

  • nltk
  • griffe
  • tenacity

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review October 1, 2024 21:51
@zsimjee zsimjee added this to the v0.6.0 release tracker milestone Oct 7, 2024
@zsimjee zsimjee changed the base branch from main to 0.6.0-dev October 18, 2024 21:05
@dtam dtam merged commit 8ceb5db into 0.6.0-dev Oct 21, 2024
12 checks passed
@dtam dtam deleted the feat/nltk-removal branch October 21, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants