Skip to content

Streaming Demo Changes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2024
Merged

Streaming Demo Changes #51

merged 15 commits into from
Jun 25, 2024

Conversation

nichwch
Copy link
Contributor

@nichwch nichwch commented Jun 21, 2024

These changes are needed for the following demo to work: https://github.com/guardrails-ai/validator-hub-ui/pull/16

Main changes:

  1. Fixes some bugs caused by adopting core schema impl interfaces.
  2. Adds error_spans to output returned by stream validate requests. We still need to patch validators to include error_spans in FailResults, however, so the demo currently does not work.
  3. Adds the Guard used in the demo to the config file.

@nichwch nichwch requested review from CalebCourier and zsimjee June 21, 2024 00:51
@nichwch nichwch marked this pull request as ready for review June 25, 2024 18:43
@nichwch nichwch force-pushed the nichwch/streaming-demo branch from 0ebcfac to 4b7dc30 Compare June 25, 2024 19:09
@CalebCourier
Copy link
Contributor

Just tested with the latest open source and existing client to server interactions are still working.
I think we can merge and release this as an alpha

@CalebCourier CalebCourier merged commit e096a20 into main Jun 25, 2024
1 check passed
@CalebCourier CalebCourier deleted the nichwch/streaming-demo branch June 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants