gio: Allow subclassing DBusProxy #1832
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gio/src/subclass/dbus_proxy.rs
Outdated
| + InitableImpl | ||
| + ObjectSubclass<Type: IsA<DBusProxy>> | ||
| { | ||
| fn g_properties_changed( |
There was a problem hiding this comment.
That's how it's called though. The signal is g-properties-changed for whatever reason :)
sdroege
reviewed
Oct 12, 2025
gio/src/subclass/dbus_proxy.rs
Outdated
Comment on lines
55
to
56
| sender_name: Option<&str>, | ||
| signal_name: &str, |
There was a problem hiding this comment.
Suggested change
| sender_name: Option<&str>, | |
| signal_name: &str, | |
| sender_name: Option<&glib::GStr>, | |
| signal_name: &glib::GStr, |
maybe so we don't have to do heap allocations for all the NUL-termination?
sdroege
previously approved these changes
Oct 12, 2025
|
Can you add an example here? |
bash
force-pushed
the
dbus-proxy-implementable
branch
from
351609b to
4fc1bed
Compare
skip-checks: true
| type ParentType = DBusProxy; | ||
| } | ||
|
|
||
| #[derived_properties] |
There was a problem hiding this comment.
Suggested change
| #[derived_properties] | |
| #[glib::derived_properties] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.