Add gio::FileMonitor subclass #1725
Conversation
fbrouille
force-pushed
the
gio_file_monitor_subclass
branch
from
8832317 to
1eeecbb
Compare
gio/tests/file_monitor.rs
Outdated
| @@ -0,0 +1,162 @@ | |||
| // Take a look at the license at the top of the repository in the LICENSE file. | |||
There was a problem hiding this comment.
Here and elsewhere, why do you provide these tests as external integration tests instead of just as part of the implementation? The latter is faster compilation-wise
There was a problem hiding this comment.
Because in #1676, tests for File and for FileEnumerator share some test utilities... Do you have an idea to do it within unit tests ?
Anyway tests for FileMonitor and for Vfs does not share test utilities so I'll move them as unit tests
There was a problem hiding this comment.
You could add a src/test_utils.rs module or so that is only included with #[cfg(test)]
There was a problem hiding this comment.
will do for other types (File, FileEnumerator)
fbrouille
force-pushed
the
gio_file_monitor_subclass
branch
3 times, most recently
from
99e752d to
19dca51
Compare
|
Also looks good to me except for the two open discussions |
fbrouille
force-pushed
the
gio_file_monitor_subclass
branch
from
49acacd to
e361652
Compare
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
fbrouille
force-pushed
the
gio_file_monitor_subclass
branch
from
e361652 to
a34c1c4
Compare
Allow custom implementation of gio::FileMonitor