WIP: Improving view mode and rendering #2566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshad1
commented
Apr 20, 2025
| } | ||
|
|
||
| @Override | ||
| public void onFsViewerNeutralButtonPressed(File currentFolder) { |
gsantner
reviewed
May 9, 2025
| @@ -76,6 +76,8 @@ public class DocumentEditAndViewFragment extends MarkorBaseFragment implements F | |||
| public static final String SAVESTATE_DOCUMENT = "DOCUMENT"; | |||
| public static final String START_PREVIEW = "START_PREVIEW"; | |||
|
|
|||
| public static float VIEW_FONT_SCALE = 100f / 15.7f; | |||
There was a problem hiding this comment.
Thanks!
Do you see that scale still fitting quite good?
There was a problem hiding this comment.
Looks good to me. But I do all my testing just my own primary device - a pixel 7 pro
harshad1
commented
May 18, 2025
| } | ||
|
|
||
| @Override | ||
| public void generateSpans() { | ||
|
|
||
| super.generateSpans(); | ||
| // Single span for the whole text - highly performant |
There was a problem hiding this comment.
Single span for the whole file.
Much faster! Much less highlighting jank!
harshad1
changed the title
harshad1
commented
May 25, 2025
| @@ -30,15 +30,15 @@ public static ApplicationObject get() { | |||
| return _app; | |||
| } | |||
|
|
|||
| public static AppSettings settings() { | |||
| public static AppSettings backupSettings() { | |||
There was a problem hiding this comment.
Making it clear that these settings are to be used as a last resort
harshad1
commented
May 25, 2025
| @Override | ||
| public AppSettings init(final Context context) { | ||
| super.init(context); | ||
| public static AppSettings get(final Context context) { |
There was a problem hiding this comment.
This is the new way of getting context
It falls back to try to do what is most correct
harshad1
commented
May 25, 2025
| @@ -63,19 +66,9 @@ protected void onCreate(@Nullable Bundle savedInstanceState) { | |||
| } | |||
| } | |||
|
|
|||
| protected void onPreCreate(@Nullable Bundle savedInstanceState) { | |||
There was a problem hiding this comment.
Just moved to onCreate()
Children ought to call super.onCreate() first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.