fix input scalar in typed debugger window issue #1295

[xcasadio]

Fixed this issue #1295

• Input scalar has unique ID
• Input scalar has unique value
• removed the unnecessary string "--" when input scalar is displayed

[coderabbitai]

Walkthrough

The changes update the input handling for memory editing in the typed debugger widget. The code now tracks new values per memory address using a map, modifies the displayNewValueInput method signature to include an address parameter and pass memory file by reference, and updates the UI logic to reflect these adjustments.

Changes

File(s)	Change Summary
src/gui/widgets/typed_debugger.cc	Refactored displayNewValueInput to accept address and memory file by reference; tracks new values per address using a map; updated UI logic and input widget IDs; removed disabled text after input.
src/gui/widgets/typed_debugger.h	Replaced single m_newValue with m_newValues map; updated displayNewValueInput signature to match new parameters.

Poem

A nibble, a hop, a byte to tweak,
Now each address has its own unique peek!
With maps for values, and widgets anew,
Debugging memory is easier to do.
Rabbits rejoice as the code refines—
Each address tracked, across the lines!
🐇💾✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7730d21 and 085afc0.

📒 Files selected for processing (2)

• src/gui/widgets/typed_debugger.cc (2 hunks)
• src/gui/widgets/typed_debugger.h (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/gui/widgets/typed_debugger.cc (1)

src/gui/widgets/typed_debugger.h (7)

• node (85-85)
• node (155-156)
• node (160-160)
• type (157-157)
• type (158-158)
• type (159-159)
• address (145-145)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (10)

src/gui/widgets/typed_debugger.h (2)

122-122: Effective solution for tracking per-address values.

This change allows tracking multiple new input values indexed by memory addresses instead of having a single shared value, ensuring each input field maintains its own state correctly.

---

159-159: Method signature improvements improve robustness.

Good changes to the method signature:

1. Taking value as const reference (const Slice&) improves efficiency by avoiding unnecessary copying
2. Using a non-const reference for memFile is appropriate since the method writes to memory
3. Adding the address parameter enables per-address value tracking

These improvements align with the PR objective to ensure each input scalar has a unique ID and value.

src/gui/widgets/typed_debugger.cc (8)

493-493: Correctly updated method call to include address parameter.

The call site has been updated to pass the current address to displayNewValueInput, which is necessary for the per-address value tracking to work properly.

---

551-552: Method signature updated to match header declaration.

The implementation correctly matches the signature declared in the header file, using the same parameter types and names.

---

562-566: Effective implementation of per-address value handling for signed char type.

The implementation now:

1. Stores the value in m_newValues map keyed by address
2. Uses the address as part of the unique ID for the ImGui input widget
3. Correctly writes the value back to memory when changed

This solves the issue mentioned in PR #1295 by ensuring each input field has a unique ID and value.

---

570-574: Similar effective implementation for unsigned char type.

The implementation pattern correctly follows the same approach as for the signed char type, maintaining consistency across different input types.

---

579-583: Short type implementation follows the same pattern.

The implementation for the signed short type correctly follows the same pattern of using the address as a key and for the unique ImGui ID.

---

586-590: Unsigned short type implementation is consistent with the pattern.

The implementation for the unsigned short type maintains consistency with the other types.

---

595-599: Int/long type implementation follows the same pattern.

The implementation for the signed int/long type correctly follows the same pattern of using the address as a key and for the unique ImGui ID.

---

602-606: Unsigned int/long type implementation is consistent.

The implementation for the unsigned int/long type maintains consistency with the other types and correctly completes the pattern across all supported primitive types.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.