Adding getters and setters to the TPage attribute. #1929
Conversation
WalkthroughThe update introduces a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TPageLoc
participant TPageAttr
User->>TPageLoc: setPageX(x), setPageY(y)
User->>TPageAttr: setPageLoc(TPageLoc)
User->>TPageAttr: getPageX(), getPageY(), getPageLoc()
User->>TPageAttr: getSemiTrans(), getColorMode()
User->>TPageAttr: hasDithering(), isDisplayAreaEnabled()
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (11)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
The PR adds new getters and setters for the TPage attribute and introduces the TPageLoc struct to facilitate manipulation of texture page locations.
- Introduces the TPageLoc struct with setters for page X and Y coordinate manipulation.
- Adds copy/move constructors, assignment operators, and a new setter to set the page location from a TPageLoc instance in TPageAttr.
- Provides getter functions in TPageAttr for page attributes and related settings.
| TPageAttr& copy(const TPageAttr& other) { | ||
| info = other.info; | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
[nitpick] The copy() method in TPageAttr is redundant since the copy assignment operator already handles member-wise copying. Consider removing it to reduce duplication and simplify maintenance.
| TPageAttr& copy(const TPageAttr& other) { | |
| info = other.info; | |
| return *this; | |
| } | |
| // Removed the redundant copy() method as the copy assignment operator already handles member-wise copying. |
Copilot uses AI. Check for mistakes.
| TPageAttr() {} | ||
| TPageAttr(TPageAttr&& other) : info(other.info) {} | ||
| TPageAttr(const TPageAttr& other) : info(other.info) {} | ||
| TPageAttr& operator=(TPageAttr&& other) { | ||
| info = other.info; | ||
| return *this; | ||
| } | ||
| TPageAttr& operator=(const TPageAttr& other) { | ||
| info = other.info; | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
[nitpick] Since the default constructor and the copy/move operators perform only trivial member-wise operations, you could consider using the default implementations (i.e., '= default') to reduce boilerplate code.
| TPageAttr() {} | |
| TPageAttr(TPageAttr&& other) : info(other.info) {} | |
| TPageAttr(const TPageAttr& other) : info(other.info) {} | |
| TPageAttr& operator=(TPageAttr&& other) { | |
| info = other.info; | |
| return *this; | |
| } | |
| TPageAttr& operator=(const TPageAttr& other) { | |
| info = other.info; | |
| return *this; | |
| } | |
| TPageAttr() = default; | |
| TPageAttr(TPageAttr&& other) = default; | |
| TPageAttr(const TPageAttr& other) = default; | |
| TPageAttr& operator=(TPageAttr&& other) = default; | |
| TPageAttr& operator=(const TPageAttr& other) = default; |
Copilot uses AI. Check for mistakes.
No description provided.