psyq-obj-parser: Handle comm symbols properly #1907
CodeScene PR Check
Quality Gate Failed
Gates Failed
Enforce advisory code health rules
(1 file with Complex Method)
Gates Passed
3 Quality Gates Passed
See analysis details in CodeScene
Reason for failure
Enforce advisory code health rules | Violations | Code Health Impact | |
---|---|---|---|
psyq-obj-parser.cc | 1 advisory rule | 2.25 → 2.24 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method psyq-obj-parser.cc: PsyqLnkFile::parse
- Complex Method psyq-obj-parser.cc: PsyqLnkFile::Relocation::generateElf
- Complex Method psyq-obj-parser.cc: PsyqLnkFile::Symbol::generateElfSymbol
Annotations
Check warning on line 508 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PsyqLnkFile::parse increases in cyclomatic complexity from 62 to 64, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 1400 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PsyqLnkFile::Relocation::generateElf increases in cyclomatic complexity from 62 to 63, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 982 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PsyqLnkFile::Symbol::generateElfSymbol increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.