-
-
Notifications
You must be signed in to change notification settings - Fork 123
New Crowdin updates #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Crowdin updates #1616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
=======================================
Coverage 9.96% 9.96%
=======================================
Files 447 447
Lines 132320 132320
=======================================
Hits 13186 13186
Misses 119134 119134 ☔ View full report in Codecov by Sentry. |
WalkthroughThis pull request updates the localization files for Greek, French, and Ukrainian in the PCSX-Redux project. The header metadata in each file is revised to include new X-Crowdin identifiers and updated language codes while removing outdated translator information. Translation entries have been modified—some cleared to indicate missing translations and others updated for accuracy. Additionally, the Ukrainian file revises its plural forms syntax and applies further formatting adjustments. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
i18n/el.po (1)
1831-1832
: Simple UI responses "yes"/"no" need translations.Basic UI responses like "yes" and "no" haven't been translated yet, which are essential for a complete localization experience.
Also applies to: 1835-1836
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
i18n/el.po
(114 hunks)i18n/fr.po
(110 hunks)i18n/uk.po
(61 hunks)
🔇 Additional comments (42)
i18n/el.po (16)
3-8
: Header information updated for standardization.The localization file header has been updated with proper metadata including project information, language settings, and Crowdin identifiers, ensuring consistency across all translation files.
Also applies to: 13-17
21-23
: Formatting adjustment for improved readability.A newline character has been added at the beginning of the message, which improves the formatting consistency.
43-43
: Translation entries cleared for technical UI elements.Several technical UI elements like "OpenGL GPU configuration" and "Clear VRAM" have had their translations removed. This appears to be intentional to ensure these can be retranslated with proper technical terminology.
Also applies to: 94-95
158-160
: Multiple technical terminology translations reset.Various technical strings related to debugging, memory operations, and UI components have had their translations cleared, including "Breakpoint triggered", "Read", "Write", and "Go to texture". This is consistent with similar updates in other language files.
Also applies to: 172-173, 176-177, 209-210
251-252
: GPU-related terminology translations removed.Multiple translations for GPU-related messages (bit depths, display modes, etc.) have been cleared. This is a good approach as technical terminology often needs specialized translation review.
Also applies to: 262-265, 319-322, 332-335, 337-340
356-357
: Hardware interface translations cleared.Translations for hardware interface elements like "Draw Offset" and "Connected" have been reset, likely to ensure technical accuracy in future translations.
Also applies to: 580-581
685-686
: Error message translation improved.The translation for the reserved opcode error message has been updated with more accurate technical terminology.
690-691
: Floating point instruction error message updated.The translation for the invalid floating point instruction error message has been improved for clarity and technical accuracy.
699-700
: Missing translation for SharedMem message.The new message about SharedMem failure has been added to the file but lacks a Greek translation. Consider prioritizing this for translation in a future update.
717-724
: BIOS loading message translation updated.The multi-line message about BIOS loading has been updated with proper formatting and clarified translation for better user understanding.
729-729
: OpenBIOS retry message translation improved.The translation for the message about retrying with OpenBIOS has been refined for clarity.
732-735
: Missing translation for OpenBIOS fallback message.The message about OpenBIOS fallback not working properly hasn't been translated. Consider including this in a future translation pass.
823-825
: Versioning and system information translations updated.Various system messages including copyright notices, CPU type information, and 8MB system emulation descriptions have been updated or added, maintaining consistency with the English versions.
Also applies to: 828-830, 1571-1573
1430-1438
: Update notifications lack translations.The newly added update notification messages don't have Greek translations. Since these are important user-facing messages, consider prioritizing them in future translation work.
Also applies to: 1454-1460, 1462-1470
1774-1777
: Version information display messages lack translations.Several new messages related to displaying version information are untranslated. These should be included in future translation work for complete localization.
Also applies to: 1779-1782, 1784-1787
1-3390
: Overall localization file update meets Crowdin standards.This update successfully standardizes the Greek localization file format with proper Crowdin identifiers and metadata, while also updating or clearing translations where needed. The pattern of changes is consistent with the described updates to other language files in the PR.
i18n/uk.po (12)
3-17
: **Header metadata correctly updated with Crowdin information. **The Ukrainian translation file's header has been properly updated with new metadata, including project version, language code, and Crowdin identifiers. These changes align with standard localization practices and provide better tracking information.
55-59
: **Several UI terms have been intentionally untranslated to ensure consistency. **Multiple UI elements now have empty translations, including control labels ("Pad 1", "Pad 2", "Select", "Start", button names like "L1", "R2"), technical terms ("BIOS", "VRAM", "GPU", "CPU"), and standard terms ("NTSC", "PAL", "OK"). This approach is often used in localization to maintain clarity for technical terminology that users may recognize better in their original form.
Also applies to: 105-105, 397-425, 505-533, 935-939, 1058-1122, 1632-1636, 3063-3063
412-413
: **Concise translation improvement for better readability. **The translation has been shortened while preserving the essential meaning, making it more readable in the UI.
690-691
: **Technical error message translations improved. **The translations for technical error messages have been refined to be more precise and natural in Ukrainian.
Also applies to: 699-700
717-724
: **BIOS-related messages improved for clarity. **The BIOS loading and fallback error message translations have been refined to be clearer and more accurate in Ukrainian.
Also applies to: 733-736
846-849
: **Networking error message translation improved. **The SIO1 TCP session closing message has been translated with better formatting and clarity.
876-878
: **Technical explanation translated more accurately. **The explanation about dithering tables being cached in memory has been translated more precisely, preserving the technical meaning.
884-887
: **Error message translation improved. **The message about debugging features not being supported with the software renderer has been made clearer in Ukrainian.
902-903
: **Warning message translation refined. **The OpenGL error reporting warning has been translated more concisely while maintaining the full meaning.
1408-1427
: **Long explanation texts reformatted and improved. **Multiple long explanation texts throughout the file have been reformatted with better line breaks and improved translations that maintain technical accuracy while being more natural in Ukrainian. This includes explanations about widescreen settings, auto-updates, emulation features, and debugging options.
Also applies to: 1456-1464, 1484-1504, 1589-1628, 1647-1694, 1709-1758, 1870-1879
12-12
: **Plural forms syntax correctly updated. **The plural forms syntax has been revised to correctly represent Ukrainian language plural rules with proper formatting.
1137-1142
: **Multi-line message reformatted for better display. **The DynaRec disassembler explanation has been reformatted to display better in the UI while preserving the meaning of the original text.
i18n/fr.po (14)
3-8
: Header metadata updates aligned with Crowdin requirements.The file header has been properly updated with the correct project information and format for Crowdin integration. Note that the language was changed from
fr
tofr_FR
, which is more specific.
13-17
: Crowdin platform identification metadata properly added.These new lines provide the necessary Crowdin integration information, including project ID, language code, and file identifiers.
21-24
: French translation properly added for ECM file detection message.A previously untranslated or improperly translated string has been correctly translated to French.
43-43
: Several UI translations have been cleared and need completion.Multiple strings throughout the file have had their translations removed (empty msgstr), particularly for UI elements and debugging features. This indicates that these translations either need review or are waiting for proper translation.
This appears to be intentional as part of the Crowdin update process, where outdated or uncertain translations are cleared for proper review by translators.
Also applies to: 95-95, 112-114, 140-142, 147-151, 162-165
717-719
: BIOS loading error message formatting improved.The formatting of the BIOS loading error message has been updated with proper line breaks for better readability.
725-726
: OpenBIOS retry message formatting updated.The retry message for OpenBIOS has been reformatted with better line breaks.
1502-1504
: Write rate message format improved.The formatting of the write rate message has been enhanced with proper line breaks.
1727-1778
: Version information format updated.The various version information strings have been properly formatted with new line indicators.
1951-1968
: Emulation option descriptions formatting improved.The description text for various emulation options has been restructured with proper line breaks to improve readability.
1995-2003
: Fast boot explanation formatting upgraded.The explanation for the fast boot option has been properly formatted with line breaks for better readability.
2011-2017
: Debugger configuration descriptions properly formatted.Several descriptions for the debugger configuration options have been reformatted with proper line breaks.
Also applies to: 2023-2028, 2053-2056
2066-2066
: Server explanation texts enhanced with better formatting.The explanations for the web server and SIO1 server/client features have been properly formatted with line breaks.
Also applies to: 2070-2094
2258-2271
: SPU usage description properly formatted.The description for SPU settings has been restructured with improved line breaks for better readability.
3358-3397
: Debugging information formatting improved.The various SPU debugging information strings have been properly formatted with new line indicators for better display.
No description provided.