Skip to content

Conversation

@iamrajiv
Copy link
Contributor

References to other Issues or PRs

Fixes: #5684

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

Signed-off-by: iamrajiv <rajivperfect007@gmail.com>
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm reminded that we have a feature that automatically creates bindings without annotations (generate_unbound_methods), how does this interact with that setting? Can you try if this breaks that? Do we need to add an option for openAPIv2 as well that generates unbound methods?

@iamrajiv
Copy link
Contributor Author

iamrajiv commented Nov 5, 2025

Hi @johanbrandhorst, thanks for the review. I tested the generate_unbound_methods flow and it works fine. OpenAPIv2 already had this flag. When enabled it auto-creates default POST bindings for methods without HTTP annotations (descriptor/services.go:46–52). When disabled those methods just have empty Bindings arrays. My len(meth.Bindings) == 0 check correctly handles that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused method request/response message rendered in OpenAPI document

2 participants