INT-2510 Remove "Evaluate" from modelTypesList.json #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielleali
approved these changes
Oct 28, 2024
HenriqueTolentino
added a commit
that referenced
this pull request
Oct 28, 2024
HenriqueTolentino
added a commit
that referenced
this pull request
Feb 11, 2025
HenriqueTolentino
added a commit
that referenced
this pull request
Feb 11, 2025
…e fixes (#521) (#530) * Remove "Evaluate" from modelTypesList.json (#449) * Model Types List update (#504) * Update labels * Update descriptions * drop redundancy from description * [INT-2592] Notebooks cleanup (#508) * remove docs/notebooks * pull in `main` * Remove deprecated notebooks * Move synthetic notebooks * Move demos into demos/navigator * move into transform folder * move to amazon * fix `demo` folder 😅 * move navft-dp to synthetics * Blueprints Updates (#510) * Updates from main * Updates to gretel.json * Copy updates in markdown files * vercel updates DO NOT MERGE TO MAIN * More updates * Update md file names * remove a bunch of icons * rename icon files * Update blueprint * remove unused hero images * Remove DGAN blueprint (resolves INT-2587) * [INT-2654] Copy & filename fixes (#521) * Fixing text * Remove unused config templates * not new * Copy corrections * synthetics update * updates gtmIds * remove notebook * Renames files --------- Co-authored-by: Nathan Walston <walston@users.noreply.github.com>
HenriqueTolentino
added a commit
that referenced
this pull request
Feb 12, 2025
* Remove "Evaluate" from modelTypesList.json (#449) * Model Types List update (#504) * Update labels * Update descriptions * drop redundancy from description * [INT-2592] Notebooks cleanup (#508) * remove docs/notebooks * pull in `main` * Remove deprecated notebooks * Move synthetic notebooks * Move demos into demos/navigator * move into transform folder * move to amazon * fix `demo` folder 😅 * move navft-dp to synthetics * Blueprints Updates (#510) * Updates from main * Updates to gretel.json * Copy updates in markdown files * vercel updates DO NOT MERGE TO MAIN * More updates * Update md file names * remove a bunch of icons * rename icon files * Update blueprint * remove unused hero images * Remove DGAN blueprint (resolves INT-2587) * [INT-2654] Copy & filename fixes (#521) * Fixing text * Remove unused config templates * not new * Copy corrections * synthetics update * updates gtmIds * remove notebook * Renames files * CORS fix (#515) --------- Co-authored-by: Nathan Walston <walston@users.noreply.github.com>
nakolean
deleted the
INT-2510-Remove-Evaluate-from-ModelTypes-list-for-workflow-builder-AND-start-from-scratch-flows
branch
nakolean
pushed a commit
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We realized while investigating a bug report that Evaluate as a standalone model type does not necessarily add much value - after much discussion on slack the decision was made to remove Evaluate from the model types list. (This decision can be found in #gretel-workflows-and-connectors)
Solution
Removing the evaluate entry from the modeType array on the modelTypesList.json
Testing
Served blueprints locally (npx http-server --cors), pointed my local development Console to that blueprint instance (changing GRETEL_BLUEPRINTS_URL) and ensured that "Evaluate" did NOT show up on the Model tile (dropdown) and it also did NOT show on the start from scratch flow on the "Select a Model" step.