-
Notifications
You must be signed in to change notification settings - Fork 2
feat: update docker flow #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
39b858a
to
0797175
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the comments this thing is good to go ⭐
0797175
to
1598874
Compare
6b06c62
to
93f3f80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On little typo is missing,
93f3f80
to
f28b774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the file internal/storage/routing/vroom/vroom.go
in the function toVroomVehicle
you use the function toOrsVehicle
but you now use Valhalla with Vroom instead of ORS.
There should be another config or so to differentiate between this or another idea that comes to your mind.
The problem that occurred to me was, that valhalla doesn't know the vehicle type driving-car
. This should be changed to auto
or so to work with the new valhalla backend for vroom.
compose.app.yaml
Outdated
- GE_ROUTING_END_POINT=9.434764259345679,54.768731253913806 | ||
- GE_ROUTING_WATERING_POINT=9.434764259345679,54.768731253913806 | ||
- GE_ROUTING_VALHALLA_HOST=http://valhalla:8002 | ||
- GE_ROUTING_VALHALLA_OPTIMIZATION_VROOM_HOST=http://vroom:2525 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port of vroom is 3000, you had it bound to 2525 in the old compose.
- GE_ROUTING_VALHALLA_OPTIMIZATION_VROOM_HOST=http://vroom:2525 | |
- GE_ROUTING_VALHALLA_OPTIMIZATION_VROOM_HOST=http://vroom:3000 |
.docker/infra/vroom/config.yml
Outdated
@@ -1,5 +1,5 @@ | |||
cliArgs: | |||
geometry: false # retrieve geometry (-g) | |||
geometry: true # retrieve geometry (-g) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this for testing or is this intended?
- add minio - add keycloak - add reverse proxy
…ackend through docker compose
f28b774
to
3ca3db4
Compare
compose.yaml
compose.app.yaml
to run backend and migrations with docker compose