-
Notifications
You must be signed in to change notification settings - Fork 19
[Issue #26][EC89] Avoid unlimited cache #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @B3ND3L, @Flow35650 please see my review feedback in PR green-code-initiative/creedengo-rules-specifications#327 |
Hi @dedece35 Before merge, there is the same typo as ecoCode PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just released "ecocode-rules-specifications" with you ecocode PR included.
Please use now the "1.6.0" version of ecocode-rules-specification. Now, your Unit Tests will be OK and thus, your build pipeline in above "Action" tab.
Second modification, please, on test files ... please check screenshots where we can see our rule error, but also native Sonar error ... please correct this one in all lines with this error. This is to have a clean test file with only our rule errors.
|
|
New rule made during ecocode challenge 24
[EC1337] (random number between 1000 / 1500) to fix unlimited cache issue : #26
TEAM : TUNGSTEN