Skip to content

[Issue #26][EC89] Avoid unlimited cache #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

B3ND3L
Copy link
Contributor

@B3ND3L B3ND3L commented May 30, 2024

New rule made during ecocode challenge 24

[EC1337] (random number between 1000 / 1500) to fix unlimited cache issue : #26

TEAM : TUNGSTEN

@dedece35
Copy link
Member

dedece35 commented Jun 2, 2024

Hi @B3ND3L, @Flow35650

please see my review feedback in PR green-code-initiative/creedengo-rules-specifications#327

@B3ND3L
Copy link
Contributor Author

B3ND3L commented Jun 3, 2024

Hi @dedece35

Before merge, there is the same typo as ecoCode PR.
I'll fix this right now.

@dedece35 dedece35 changed the title [Issue #26][EC1337] Avoid unlimited cache [Issue #26][EC89] Avoid unlimited cache Jun 3, 2024
@dedece35 dedece35 linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just released "ecocode-rules-specifications" with you ecocode PR included.
Please use now the "1.6.0" version of ecocode-rules-specification. Now, your Unit Tests will be OK and thus, your build pipeline in above "Action" tab.
Second modification, please, on test files ... please check screenshots where we can see our rule error, but also native Sonar error ... please correct this one in all lines with this error. This is to have a clean test file with only our rule errors.

@dedece35
Copy link
Member

dedece35 commented Jun 3, 2024

I've just released "ecocode-rules-specifications" with you ecocode PR included. Please use now the "1.6.0" version of ecocode-rules-specification. Now, your Unit Tests will be OK. Second modification, please, on test files ... please check screenshots where we can see our rule error, but also native Sonar error ... please correct this one in all lines with this error. This is to have a clean test file with only our rule errors.

Capture d’écran 2024-06-03 à 20 56 14

Copy link

sonarqubecloud bot commented Jun 5, 2024

@dedece35 dedece35 merged commit c077c88 into green-code-initiative:main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EC89] Avoid using function cache without limit
2 participants