Skip to content

fix(GCI82): fix rule to handle record types and adjust test cases (#104) #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vimarie
Copy link

@vimarie vimarie commented May 20, 2025

This PR resolves the issue #104

Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you correct the conflict in the CHANGELOG file?
After this, I think we will good to go 🚀 Thank you for the contribution!

@cali0pe cali0pe force-pushed the fix/challenge25-GCI82-manage-record branch from b5483a1 to 4618de8 Compare June 6, 2025 09:53
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 I let @dedece35 do the final validation!

@utarwyn utarwyn requested review from MP-Aubay and dedece35 June 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants