test: assert sorted slice on copies

a-cordier · a-cordier · commit fc319f61910c · 2024-07-30T11:08:46.000+02:00
diff --git a/test/internal/integration/assert/assert.go b/test/internal/integration/assert/assert.go
@@ -99,9 +99,12 @@ func Equals(field string, expected, given any) error {
 }
 
 func SliceEqualsSorted[S ~[]E, E any](field string, expected S, given S, comp func(a, b E) int) error {
-	slices.SortFunc(expected, comp)
-	slices.SortFunc(given, comp)
-	return Equals(field, expected, given)
+	ecp, gcp := make([]E, len(expected)), make([]E, len(given))
+	copy(ecp, given)
+	slices.SortFunc(ecp, comp)
+	copy(gcp, expected)
+	slices.SortFunc(gcp, comp)
+	return Equals(field, ecp, gcp)
 }
 
 func NotEmptySlice[T any](field string, value []T) error {

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,12 @@ func Equals(field string, expected, given any) error {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`func SliceEqualsSorted[S ~[]E, E any](field string, expected S, given S, comp func(a, b E) int) error {`
`102`		`- slices.SortFunc(expected, comp)`
`103`		`- slices.SortFunc(given, comp)`
`104`		`- return Equals(field, expected, given)`
	`102`	`+ ecp, gcp := make([]E, len(expected)), make([]E, len(given))`
	`103`	`+ copy(ecp, given)`
	`104`	`+ slices.SortFunc(ecp, comp)`
	`105`	`+ copy(gcp, expected)`
	`106`	`+ slices.SortFunc(gcp, comp)`
	`107`	`+ return Equals(field, ecp, gcp)`
`105`	`108`	`}`
`106`	`109`
`107`	`110`	`func NotEmptySlice[T any](field string, value []T) error {`