refactor: move path validation to admission controller

Author: a-cordier

api/model/api/v4/api.go

@@ -17,7 +17,6 @@ package v4
 
 import (
 	"fmt"
-	"net/url"
 
 	"github.com/gravitee-io/gravitee-kubernetes-operator/api/model/api/base"
 	"github.com/gravitee-io/gravitee-kubernetes-operator/pkg/types/k8s/custom"
@@ -199,13 +198,7 @@ func (api *Api) GetDefinitionVersion() custom.ApiDefinitionVersion {
 func (api *Api) GetContextPaths() ([]string, error) {
 	paths := make([]string, 0)
 	for _, l := range api.Listeners {
-		for _, s := range parseListener(l) {
-			p, err := url.Parse(s)
-			if err != nil {
-				return paths, err
-			}
-			paths = append(paths, p.String())
-		}
+		paths = append(paths, parseListener(l)...)
 	}
 	return paths, nil
 }

docs/api/reference.md

@@ -7369,7 +7369,7 @@ Application is the main resource handled by the Kubernetes Operator
         <td><b>clientId</b></td>
         <td>string</td>
         <td>
-          The ClientId identifying the application. This field is required when subscribing to an OAUTH2 / JWT plan.<br/>
+          The ClientID identifying the application. This field is required when subscribing to an OAUTH2 / JWT plan.<br/>
         </td>
         <td>false</td>
       </tr><tr>
@@ -7551,7 +7551,7 @@ Application settings
         <td><b>client_id</b></td>
         <td>string</td>
         <td>
-          ClientId is the client id of the application<br/>
+          ClientID is the client id of the application<br/>
         </td>
         <td>false</td>
       </tr></tbody>

helm/gko/crds/gravitee.io_applications.yaml

@@ -75,7 +75,7 @@ spec:
                   when displaying it on the portal
                 type: string
               clientId:
-                description: The ClientId identifying the application. This field
+                description: The ClientID identifying the application. This field
                   is required when subscribing to an OAUTH2 / JWT plan.
                 type: string
               contextRef:
@@ -164,7 +164,7 @@ spec:
                   app:
                     properties:
                       client_id:
-                        description: ClientId is the client id of the application
+                        description: ClientID is the client id of the application
                         type: string
                       type:
                         description: Application Type

internal/admission/api/v4/validate.go

@@ -16,6 +16,7 @@ package v4
 
 import (
 	"context"
+	"net/url"
 	"slices"
 
 	v4 "github.com/gravitee-io/gravitee-kubernetes-operator/api/model/api/v4"
@@ -61,6 +62,12 @@ func validateNoConflictingPath(ctx context.Context, api custom.ApiDefinitionReso
 		return errors.NewSevere(err.Error())
 	}
 	for _, apiPath := range apiPaths {
+		if _, pErr := url.Parse(apiPath); pErr != nil {
+			return errors.NewSevere(
+				"path [%s] is invalid",
+				apiPath,
+			)
+		}
 		if slices.Contains(existingPaths, apiPath) {
 			return errors.NewSevere(
 				"invalid API context path [%s]. Another API with the same path already exists",