Skip to content

Rewrite requests to /graphql #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

The swapi graphql demo has been broken for a while as it points to the netlify path returning a 301, this should be fixed by graphql/swapi-graphql#232 but the link could look cleaner so instead this requests to /graphql

Copy link

vercel bot commented Jan 7, 2025

@JoviDeCroock is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@benjie
Copy link
Member

benjie commented Jan 7, 2025

Redirecting all paths to /graphql feels wrong - what if we want to serve GraphiQL assets from here? Why are the underlying links wrong?

@JoviDeCroock
Copy link
Member Author

Fair enough, we could keep doing what we do now. We'll need to fix the OPTIONS request though on swapi-graphql

@JoviDeCroock JoviDeCroock deleted the patch-1 branch January 7, 2025 19:22
@benjie
Copy link
Member

benjie commented Jan 8, 2025

What URLs is this actually intending to redirect? Maybe we can add redirects for those specific paths, rather than a catchall?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants