-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update serving over HTTP docs. #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent expansion! Many of these suggested edits are incredibly minor nits 🙌
Co-authored-by: Benjie <benjie@jemjie.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - excellent work!
If there were no errors returned, the `"errors"` field should not be present on the response. If no data is returned, [according to the GraphQL spec](https://spec.graphql.org/October2021/#sec-Data), the `"data"` field should only be included if no errors occurred during execution. | ||
If no errors were returned, the `errors` field must not be present in the response. If errors occurred before execution could start, the `errors` field must include these errors and the `data` field must not be present in the response. The `extensions` field is optional and information provided here will be at the discretion of the GraphQL implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@graphql/tsc please confirm I'm not missing something about the second sentence in the original text... I couldn't quite make sense of it?
If no data is returned, according to the GraphQL spec, the
"data"
field should only be included if no errors occurred during execution.
We've instead replaced it with the following, but I want to be sure we've not missed something:
If errors occurred before execution could start, the
errors
field must include these errors and thedata
field must not be present in the response.
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Description
This PR contains updated "Serving over HTTP" content for the Learn docs. Key changes include:
@benjie @jorydotcom