Skip to content

Pull copyright and license into repo-level LICENSE.md #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leebyron
Copy link
Collaborator

@leebyron leebyron commented Jul 1, 2025

Ensures the repo has a top level LICENSE.md file without concern of skew from the spec text by way of an import reference.

This also moves the License and conformance section into an appendix, and does some editorial to the spec introduction including adding links about contribution. Hopefully this makes it easier to read since the ToC is much more likely to be above the fold.

@leebyron leebyron requested review from benjie and a team July 1, 2025 21:22
@leebyron leebyron added the ✏️ Editorial PR is non-normative or does not influence implementation label Jul 1, 2025
Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 62e5c1f
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/6864bb4638fdfe000820a226
😎 Deploy Preview https://deploy-preview-1172--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this reduction in the overhead of getting into the meat of the specification 👍

Here's a couple changes I'd like to see, but am not overly attached to.

[GraphQL Specification Project](https://graphql.org/community/) was established
also in 2019 as the Joint Development Foundation Projects, LLC, GraphQL Series.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would restore this paragraph break.

[graphql/graphql-spec](https://github.com/graphql/graphql-spec/). Contributions
are managed by the
[GraphQL Working Group](https://github.com/graphql/graphql-wg), hosted by the
[GraphQL TSC](https://github.com/graphql/graphql-wg/blob/main/GraphQL-TSC.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use an abbreviation the first time the term is introduced:

Suggested change
[GraphQL TSC](https://github.com/graphql/graphql-wg/blob/main/GraphQL-TSC.md).
[GraphQL Technical Steering Committee](https://github.com/graphql/graphql-wg/blob/main/GraphQL-TSC.md).

(Feel free to append (TSC) if we want to refer to it again, but I don't think we do.)

@@ -0,0 +1,64 @@
# D. Appendix: Conformance & Licensing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have these be in the same appendix? I feel like having an extra focussed appendix is not too costly, and "conformance" and "licensing" feel somewhat separate to me.


GraphQL has evolved and may continue to evolve in future editions of this
specification. Previous editions of the GraphQL specification can be found at
permalinks that match their
[release tag](https://github.com/graphql/graphql-spec/releases). The latest
working draft release can be found at
[https://spec.graphql.org/draft](https://spec.graphql.org/draft).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep a couple of the main call-outs to the appendices here; especially where reading them up-front may be beneficial to some readers. Perhaps:

Suggested change
See [Appendix A](#sec-Appendix-Notation-Conventions) for more details about the
definition of algorithms, data collections, and other notational conventions
used in this document.
A conforming implementation of GraphQL must fulfil all normative requirements.
Conformance requirements expressed as algorithms and data collections can be
fulfilled by an implementation of this specification in any way as long as the
perceived result is equivalent. See [Appendix D](#sec-Appendix-Conformance) for
details.

(Aside: should that "algorithms and data collections" be "algorithms or data collections"?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants