switch to esm-only with development condition enabling dev-instanceOf-check

.github/workflows/ci.yml

@@ -145,7 +145,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node_version_to_setup: [16, 18, 19]
+        node_version_to_setup: [20, 22, 23]
     permissions:
       contents: read # for actions/checkout
     steps:

.node-version

@@ -1 +1 @@
-v20
+v22

cspell.yml

@@ -39,8 +39,9 @@ overrides:
       - URQL
       - tada
       - Graphile
-      - precompiled
-      - debuggable
+      - precompileds
+      - Rollup
+      - Turbopack
 
 validateDirectives: true
 ignoreRegExpList:
@@ -67,6 +68,8 @@ words:
   # TODO: contribute upstream
   - deno
   - hashbang
+  - Rspack
+  - Rsbuild
 
   # Website tech
   - Nextra

eslint.config.mjs

@@ -764,7 +764,7 @@ export default tsConfig(
       'n/no-missing-import': [
         'error',
         {
-          allowModules: ['graphql', 'graphql-esm'],
+          allowModules: ['graphql'],
         },
       ],
       'n/no-missing-require': [

integrationTests/README.md

@@ -1 +1,43 @@
-# TBD
+# Integration Tests
+
+This directory contains integration tests for GraphQL.js across different environments and bundlers, testing basic GraphQL.JS functionality, as well as development mode and production mode behavior.
+
+Tests are run via the main integration test suite in `resources/integration-test.ts`.
+
+## Test Structure
+
+### Basic GraphQL.JS Functionality Tests
+
+Each subdirectory represents a different environment/bundler:
+
+- `node` - tests for supported Node.js versions
+- `ts` - tests for supported Typescript versions
+- `webpack` - tests for Webpack
+
+### Verifying Development Mode Tests
+
+Each subdirectory represents a different environment/bundler demonstrating enabling development mode via conditional exports or by explicitly importing `graphql/dev`:
+
+- `dev-bun/`: via `bun --conditions=development test.js`
+- `dev-deno-implicit`: via `deno run --unstable-node-conditions=development test.js`
+- `dev-deno-explicit`: via `import 'graphql/dev'`
+- `dev-node-implicit`: via `node --conditions=development test.js`
+- `dev-node-explicit`: via `import 'graphql/dev'`
+- `dev-webpack`: via `{resolve: { conditionNames: ['development'] } }`
+- `dev-rspack`: via `{resolve: { conditionNames: ['development'] } }`
+- `dev-esbuild`: via `esbuild --conditions=development test.js`
+- `dev-rollup`: via `@rollup/plugin-node-resolve` with `conditions: ['development']`
+- `dev-swc`: via `import 'graphql/dev'`
+
+### Verifying Production Mode Tests
+
+Each subdirectory represents a different environment/bundler demonstrating production mode when development mode is not enabled:
+
+- `prod-bun/`: via `bun test.js`
+- `prod-deno`: via `deno run test.js`
+- `prod-node`: via `node test.js`
+- `prod-webpack`: via default Webpack configuration
+- `prod-rspack`: via default Rspack configuration
+- `prod-esbuild`: via `esbuild test.js`
+- `prod-rollup`: via default Rollup configuration
+- `prod-swc`: via default SWC configuration

integrationTests/dev-bun/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js development condition should work with Bun",
+  "private": true,
+  "scripts": {
+    "test": "docker run --rm --volume \"$PWD:/usr/src/app\" -w /usr/src/app oven/bun:latest bun --conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-bun/test.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-deno-explicit/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js explicit development import should work with Deno",
+  "private": true,
+  "scripts": {
+    "test": "docker run --rm --volume \"$PWD:/usr/src/app\" -w /usr/src/app denoland/deno:latest deno run test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-deno-explicit/test.js

@@ -0,0 +1,20 @@
+// eslint-disable-next-line import/no-unassigned-import, simple-import-sort/imports
+import 'graphql/dev';
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-deno-implicit/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js development condition should work with Deno",
+  "private": true,
+  "scripts": {
+    "test": "docker run --rm --volume \"$PWD:/usr/src/app\" -w /usr/src/app denoland/deno:latest deno run --unstable-node-conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-deno-implicit/test.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-esbuild/package.json

@@ -0,0 +1,13 @@
+{
+  "description": "graphql-js development condition should work with esbuild",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": "esbuild src/index.js --bundle --outfile=dist/bundle.js --format=esm --conditions=development,module",
+    "test": "npm run build && node dist/bundle.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz",
+    "esbuild": "^0.25.0"
+  }
+}

integrationTests/dev-esbuild/src/index.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-node-explicit/bootstrap.js

@@ -0,0 +1,3 @@
+/* eslint-disable import/no-unassigned-import */
+import 'graphql/dev';
+import './test.js';

integrationTests/dev-node-explicit/package.json

@@ -0,0 +1,11 @@
+{
+  "description": "explicit graphql-js development mode should work with node",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "test": "node bootstrap.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-node-explicit/test.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-node-implicit/package.json

@@ -0,0 +1,11 @@
+{
+  "description": "graphql-js development condition should work with node",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "test": "node --conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-node-implicit/test.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-rollup/package.json

@@ -0,0 +1,14 @@
+{
+  "description": "graphql-js development condition should work with Rollup",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": "rollup -c",
+    "test": "npm run build && node dist/bundle.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz",
+    "rollup": "^4.0.0",
+    "@rollup/plugin-node-resolve": "^15.0.0"
+  }
+}

integrationTests/dev-rollup/rollup.config.js

@@ -0,0 +1,18 @@
+// eslint-disable-next-line n/no-missing-import
+import resolve from '@rollup/plugin-node-resolve';
+
+const rollupConfig = {
+  input: 'src/index.js',
+  output: {
+    file: 'dist/bundle.js',
+    format: 'es',
+  },
+  plugins: [
+    resolve({
+      exportConditions: ['development'],
+    }),
+  ],
+};
+
+// eslint-disable-next-line no-restricted-exports, import/no-default-export
+export default rollupConfig;

integrationTests/dev-rollup/src/index.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-rspack/package.json

@@ -0,0 +1,12 @@
+{
+  "description": "graphql-js development condition should work with Rspack",
+  "private": true,
+  "scripts": {
+    "test": "rspack --mode=development && node dist/main.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz",
+    "@rspack/core": "^1.0.0",
+    "@rspack/cli": "^1.0.0"
+  }
+}

integrationTests/dev-rspack/rspack.config.js

@@ -0,0 +1,20 @@
+import { fileURLToPath } from 'node:url';
+
+const rspack = {
+  entry: './src/index.js',
+  output: {
+    filename: 'main.js',
+    path: fileURLToPath(new URL('dist', import.meta.url)),
+    library: {
+      type: 'commonjs2',
+    },
+  },
+  mode: 'development',
+  target: 'node',
+  resolve: {
+    conditionNames: ['development', 'import', 'node'],
+  },
+};
+
+// eslint-disable-next-line no-restricted-exports, import/no-default-export
+export default rspack;

integrationTests/dev-rspack/src/index.js

@@ -0,0 +1,18 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit dev import mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-swc/.swcrc

@@ -0,0 +1,12 @@
+{
+  "jsc": {
+    "parser": {
+      "syntax": "ecmascript",
+      "jsx": false
+    },
+    "target": "es2020"
+  },
+  "module": {
+    "type": "es6"
+  }
+}