-
Notifications
You must be signed in to change notification settings - Fork 2k
Updates to schema coordinates (#3044) #4422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to schema coordinates (#3044) #4422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this ❤️
Code looks good, mainly feeling conflicted about conflating enum-members and type-fields. Input-fields and type-fields feel similar compared to enum-members |
- Add error handling as proposed by Benjie
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
@JoviDeCroock has a good point, and perhaps it would actually be better to represent this in the schema coordinates syntax itself:
|
I have raised magicmark/graphql-spec#1; if we agree then I'll also make these changes to this branch and get it merged into #3044 |
…ndling Error handling
ack. @benjie done! added the enum changes. |
Merging this even though it doesn't pass CI under the instruction of the champion 👍 |
Updates to #3044
Implements the new spec changes:
FieldCoordinate
,ArgumentCoordinate
etc)MyEnum::value
separator syntax