Revive for..of optimization #4208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
revive-for-of-optimisation
branch
from
6f9f231 to
f1b4893
Compare
This comment has been minimized.
This comment has been minimized.
JoviDeCroock
force-pushed
the
revive-for-of-optimisation
branch
from
f1b4893 to
2cffe00
Compare
@JoviDeCroock Something went wrong, please check log. |
JoviDeCroock
force-pushed
the
revive-for-of-optimisation
branch
2 times, most recently
from
6572923 to
df82c97
Compare
JoviDeCroock
force-pushed
the
revive-for-of-optimisation
branch
2 times, most recently
from
945a836 to
372ecd8
Compare
JoviDeCroock
force-pushed
the
revive-for-of-optimisation
branch
from
372ecd8 to
fb887db
Compare
|
To be consistent we'd have to translate Set/Map however we rely on those being mutated during runtime which does not boat well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives the effort for us to use ES6 features without sacrificing performance.
We'll transpile
for..ofstatements toThere's a potential optimisation in here to extract
x.lengthoutside of the loop so we don't have to accesslengthevery time. Another thing we'll have to transpile is array destructuring.With the automated approach like here we'll still have a lot of
for..ofwhere we invoke the iterator of i.e. a map.Related to #3691