chore(perf): improve performance of iterator usage #4084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
After getting the benchmarks to run, this seems resolved 😅 sorry for the PR's |
Even if this didn’t pan out, it’s super useful that you investigated it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised why I didn't see performance differences in #4080 I was targeting the wrong branch 😅 This takes the transform used in #3691 and updates it to recent TS versions and adds one for Array destructuring.
The transform that takes on
for..ofwill only optimize usage that isn't relying oniteratori.e. plain arrays vsMap.I have been seeing issues running the benchmarks, looking into that atm.