chore(performance): optimize regressed for..of and array destructuring performance

.babelrc-deno.json

@@ -1,6 +1,8 @@
 {
   "plugins": [
     "@babel/plugin-syntax-typescript",
+    ["@babel/plugin-transform-for-of", { "assumeArray": true }],
+    "@babel/plugin-transform-destructuring",
     ["./resources/add-extension-to-import-paths", { "extension": "ts" }],
     "./resources/inline-invariant"
   ]

.babelrc-npm.json

@@ -1,6 +1,8 @@
 {
   "plugins": [
     "@babel/plugin-transform-typescript",
+    ["@babel/plugin-transform-for-of", { "assumeArray": true }],
+    "@babel/plugin-transform-destructuring",
     "./resources/inline-invariant"
   ],
   "env": {

.babelrc.json

@@ -1,5 +1,9 @@
 {
-  "plugins": ["@babel/plugin-transform-typescript"],
+  "plugins": [
+    "@babel/plugin-transform-typescript",
+    ["@babel/plugin-transform-for-of", { "assumeArray": true }],
+    "@babel/plugin-transform-destructuring"
+  ],
   "presets": [
     [
       "@babel/preset-env",

package.json

@@ -54,6 +54,8 @@
   "devDependencies": {
     "@babel/core": "7.17.9",
     "@babel/plugin-syntax-typescript": "7.16.7",
+    "@babel/plugin-transform-destructuring": "^7.24.5",
+    "@babel/plugin-transform-for-of": "^7.24.1",
     "@babel/plugin-transform-typescript": "7.16.8",
     "@babel/preset-env": "7.16.11",
     "@babel/register": "7.17.7",

src/execution/execute.ts

@@ -405,7 +405,7 @@ function executeFieldsSerially(
   fields: Map<string, ReadonlyArray<FieldNode>>,
 ): PromiseOrValue<ObjMap<unknown>> {
   return promiseReduce(
-    fields.entries(),
+    Array.from(fields.entries()),
     (results, [responseName, fieldNodes]) => {
       const fieldPath = addPath(path, responseName, parentType.name);
       const result = executeField(
@@ -446,7 +446,8 @@ function executeFields(
   let containsPromise = false;
 
   try {
-    for (const [responseName, fieldNodes] of fields.entries()) {
+    const fieldsEntries = Array.from(fields.entries());
+    for (const [responseName, fieldNodes] of fieldsEntries) {
       const fieldPath = addPath(path, responseName, parentType.name);
       const result = executeField(
         exeContext,

src/jsutils/promiseForObject.ts

@@ -12,7 +12,8 @@ export function promiseForObject<T>(
 ): Promise<ObjMap<T>> {
   return Promise.all(Object.values(object)).then((resolvedValues) => {
     const resolvedObject = Object.create(null);
-    for (const [i, key] of Object.keys(object).entries()) {
+    const entries = Array.from(Object.keys(object).entries());
+    for (const [i, key] of entries) {
       resolvedObject[key] = resolvedValues[i];
     }
     return resolvedObject;

src/jsutils/promiseReduce.ts

@@ -9,7 +9,7 @@ import type { PromiseOrValue } from './PromiseOrValue';
  * return a Promise.
  */
 export function promiseReduce<T, U>(
-  values: Iterable<T>,
+  values: Array<T>,
   callbackFn: (accumulator: U, currentValue: T) => PromiseOrValue<U>,
   initialValue: PromiseOrValue<U>,
 ): PromiseOrValue<U> {

src/language/location.ts

@@ -20,7 +20,8 @@ export function getLocation(source: Source, position: number): SourceLocation {
   let lastLineStart = 0;
   let line = 1;
 
-  for (const match of source.body.matchAll(LineRegExp)) {
+  const matches = Array.from(source.body.matchAll(LineRegExp))
+  for (const match of matches) {
     invariant(typeof match.index === 'number');
     if (match.index >= position) {
       break;

src/type/schema.ts

@@ -213,7 +213,7 @@ export class GraphQLSchema {
     // Keep track of all implementations by interface name.
     this._implementationsMap = Object.create(null);
 
-    for (const namedType of allReferencedTypes) {
+    for (const namedType of Array.from(allReferencedTypes)) {
       if (namedType == null) {
         continue;
       }