-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[3] GraphiQL 5 x Monaco editor / Monaco-GraphQL / JSONC variables/headers #3234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-10
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a2765fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared
|
another thing I'll be cleaning up is a lot of no longer needed - for example, most of |
rebased! I will start a pre-release process for this branch. any changes we merge to this branch will be merged as a pre-release |
✅ Deploy Preview for graphiql-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dimaMachina I am going to revive this, and manually re-create these changes on a new branch. I will try to keep tooling changes minimal for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaks to human-facing grammar, punctuation, etc., for clarity and consistency
packages/graphiql-react/src/editor/components/header-editor.tsx
Outdated
Show resolved
Hide resolved
packages/graphiql-react/src/editor/components/variable-editor.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-10 #3234 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 35 35
Lines 3086 3086
Branches 950 934 -16
=======================================
Hits 1974 1974
Misses 1107 1107
Partials 5 5
🚀 New features to boost your workflow:
|
1941688
to
64c4dae
Compare
closes #2326 #780 #3874 #2971 #3957 #3956 #3788 #3387
Migrate Codemirror editors to Monaco editor
Setup Monaco GraphQL
Resize works
Configure save operations/variables/headers values to
storage
save
operationName
to storagecolor theme should be adjusted to actual codemirror color theme on dark/light mode (currently hard copied from
graphiql
prototype)validation errors don't appear on the initial loading