feat(SQO): Introduce circuit breaker. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update service_quality_oracle.py Update service_quality_oracle.py Update service_quality_oracle.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
The SQO can enter an endless loop of restarts due to the current configuration. For example, if we have an issue with our RPC providers, that will not be resolved on retrying, then we can end up with an endless loop of the service failing, restarting, re-querying BigQuery and reattempting to post a transaction on-chain. This loop is expensive and pointless furthermore it may not be caught for hours.
Key changes
src/utils/circuit_breaker.pymodule who's functions are called to record service failures, if the service fails too many times in a short duration (default is 3 failures in 60 mins) then we exit with error code 0, so the service is prevented from an endless loop of restarts, which could be expensive in BigQuery. An engineer can then take a look at the underlying issue and solve the problem if this failure mode were to ever arrise./docs/technical-design.mdinside the codebase.