fix(server/http): graphql server compliance issues #4507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YassinEldeeb
force-pushed
the
fix-compliance-issues-with-gql-server
branch
from
40b9611 to
d4544f9
Compare
leoyvens
reviewed
Jun 12, 2023
server/http/src/service.rs
Outdated
| @@ -229,15 +235,80 @@ where | |||
| /// Handles 404s. | |||
There was a problem hiding this comment.
This comment needs to be updated.
|
This would break any consumer which sends requests with a content-type or content-length. While that's reasonable and spec-compliant, I wouldn't want to roll this out without some switch to turn this off, in case any users report issues, so they have time to update their apps. |
YassinEldeeb
force-pushed
the
fix-compliance-issues-with-gql-server
branch
from
4903e66 to
ed01c1b
Compare
|
Hey @leoyvens, thanks for the feedback! Using the |
leoyvens
reviewed
Jul 24, 2023
server/http/src/test_utils.rs
Outdated
| @@ -7,14 +7,15 @@ use hyper::{header::ACCESS_CONTROL_ALLOW_ORIGIN, Body, Response}; | |||
| pub fn assert_successful_response( | |||
| response: Response<Body>, | |||
| ) -> serde_json::Map<String, serde_json::Value> { | |||
| assert_eq!(response.status(), StatusCode::OK); | |||
| // assert_eq!(response.status(), StatusCode::OK); | |||
There was a problem hiding this comment.
Should this commented out code be removed?
leoyvens
reviewed
Jul 24, 2023
server/http/src/test_utils.rs
Outdated
| @@ -51,6 +52,7 @@ pub fn assert_error_response( | |||
| let json: serde_json::Value = | |||
| serde_json::from_str(&body).expect("GraphQL response is not valid JSON"); | |||
|
|
|||
| println!("{:?}", json); | |||
There was a problem hiding this comment.
Should the two println! in this file be removed?
|
Just two tiny comments before we can merge. |
|
I've cleaned up the log and uncommented check |
leoyvens
approved these changes
Jul 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4037