feat(lsp): Add submodule information to module hover #2309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
alex-snezhko,
ospencer,
peblair and
phated
as code owners
|
It looks like the actions runner is now using clang 17 so the tests are failing, which means this and any other prs are blocked until we get the binaryen.ml and ocaml 5 upgrades in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pr adding the provided submodules to module hover.
I was wondering separately if we should change the way sourcetree works slightly so in cases like
Stream.G|et.charwith|being the cursor it returns the hover forStream.Getrather than the hover for the value.