Fix the timeout conversion so it's consistent

The timeout is assumed to be in milliseconds when the user sets it
using the provided APIs on browserContext and page. The issue is that
internally it's assumed to be seconds.

This commit fixes that for the default timeout so it's always
assumed to be milliseconds.

Author: ankur22

common/element_handle.go

@@ -249,7 +249,7 @@ func (h *ElementHandle) dblClick(p *Position, opts *MouseClickOptions) error {
 }
 
 func (h *ElementHandle) defaultTimeout() time.Duration {
-	return time.Duration(h.frame.manager.timeoutSettings.timeout()) * time.Second
+	return time.Duration(h.frame.manager.timeoutSettings.timeout()) * time.Millisecond
 }
 
 func (h *ElementHandle) dispatchEvent(_ context.Context, typ string, eventInit goja.Value) (any, error) {

common/frame.go

@@ -198,7 +198,7 @@ func (f *Frame) detach() {
 }
 
 func (f *Frame) defaultTimeout() time.Duration {
-	return time.Duration(f.manager.timeoutSettings.timeout()) * time.Second
+	return time.Duration(f.manager.timeoutSettings.timeout()) * time.Millisecond
 }
 
 func (f *Frame) document() (*ElementHandle, error) {
@@ -1738,7 +1738,7 @@ func (f *Frame) WaitForNavigation(opts goja.Value) (api.Response, error) {
 		"fid:%s furl:%s", f.ID(), f.URL())
 
 	parsedOpts := NewFrameWaitForNavigationOptions(
-		time.Duration(f.manager.timeoutSettings.timeout()) * time.Second)
+		time.Duration(f.manager.timeoutSettings.timeout()) * time.Millisecond)
 	if err := parsedOpts.Parse(f.ctx, opts); err != nil {
 		k6ext.Panic(f.ctx, "parsing wait for navigation options: %w", err)
 	}

common/page.go

@@ -223,7 +223,7 @@ func (p *Page) closeWorker(sessionID target.SessionID) {
 }
 
 func (p *Page) defaultTimeout() time.Duration {
-	return time.Duration(p.timeoutSettings.timeout()) * time.Second
+	return time.Duration(p.timeoutSettings.timeout()) * time.Millisecond
 }
 
 func (p *Page) didClose() {

common/timeout.go

@@ -45,5 +45,5 @@ func (t *TimeoutSettings) timeout() int64 {
 	if t.parent != nil {
 		return t.parent.timeout()
 	}
-	return int64(DefaultTimeout.Seconds())
+	return int64(DefaultTimeout.Milliseconds())
 }

common/timeout_test.go

@@ -111,7 +111,7 @@ func testTimeoutSettingsTimeout(t *testing.T) {
 	ts := NewTimeoutSettings(nil)
 
 	// Assert default timeout value is used
-	assert.Equal(t, int64(DefaultTimeout.Seconds()), ts.timeout())
+	assert.Equal(t, int64(DefaultTimeout.Milliseconds()), ts.timeout())
 
 	// Assert custom default timeout is used
 	ts.setDefaultTimeout(100)
@@ -125,7 +125,7 @@ func testTimeoutSettingsTimeoutWithParent(t *testing.T) {
 	tsWithParent := NewTimeoutSettings(ts)
 
 	// Assert default timeout value is used
-	assert.Equal(t, int64(DefaultTimeout.Seconds()), tsWithParent.timeout())
+	assert.Equal(t, int64(DefaultTimeout.Milliseconds()), tsWithParent.timeout())
 
 	// Assert custom default timeout from parent is used
 	ts.setDefaultTimeout(1000)