Fix the timeout conversion so it's consistent

The timeout is assumed to be in milliseconds when the user sets it
using the provided APIs on browserContext and page. The issue is that
internally it's assumed to be seconds.

This commit fixes that for the default navigation so it's always
assumed to be milliseconds.

Author: ankur22

common/barrier.go

@@ -32,7 +32,7 @@ func (b *Barrier) AddFrameNavigation(frame *Frame) {
 		atomic.AddInt64(&b.count, 1)
 		select {
 		case <-frame.ctx.Done():
-		case <-time.After(time.Duration(frame.manager.timeoutSettings.navigationTimeout()) * time.Second):
+		case <-time.After(time.Duration(frame.manager.timeoutSettings.navigationTimeout()) * time.Millisecond):
 			b.errCh <- ErrTimedOut
 		case <-ch:
 			b.ch <- true

common/frame.go

@@ -883,7 +883,7 @@ func (f *Frame) Goto(url string, opts goja.Value) (api.Response, error) {
 		defaultReferer = netMgr.extraHTTPHeaders["referer"]
 		parsedOpts     = NewFrameGotoOptions(
 			defaultReferer,
-			time.Duration(f.manager.timeoutSettings.navigationTimeout())*time.Second,
+			time.Duration(f.manager.timeoutSettings.navigationTimeout())*time.Millisecond,
 		)
 	)
 	if err := parsedOpts.Parse(f.ctx, opts); err != nil {

common/timeout.go

@@ -35,7 +35,7 @@ func (t *TimeoutSettings) navigationTimeout() int64 {
 	if t.parent != nil {
 		return t.parent.navigationTimeout()
 	}
-	return int64(DefaultTimeout.Seconds())
+	return int64(DefaultTimeout.Milliseconds())
 }
 
 func (t *TimeoutSettings) timeout() int64 {

common/timeout_test.go

@@ -80,7 +80,7 @@ func testTimeoutSettingsNavigationTimeout(t *testing.T) {
 	ts := NewTimeoutSettings(nil)
 
 	// Assert default timeout value is used
-	assert.Equal(t, int64(DefaultTimeout.Seconds()), ts.navigationTimeout())
+	assert.Equal(t, int64(DefaultTimeout.Milliseconds()), ts.navigationTimeout())
 
 	// Assert custom default timeout is used
 	ts.setDefaultNavigationTimeout(100)
@@ -94,7 +94,7 @@ func testTimeoutSettingsNavigationTimeoutWithParent(t *testing.T) {
 	tsWithParent := NewTimeoutSettings(ts)
 
 	// Assert default timeout value is used
-	assert.Equal(t, int64(DefaultTimeout.Seconds()), tsWithParent.navigationTimeout())
+	assert.Equal(t, int64(DefaultTimeout.Milliseconds()), tsWithParent.navigationTimeout())
 
 	// Assert custom default timeout from parent is used
 	ts.setDefaultNavigationTimeout(1000)