Fix error source coming from getFrames function #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yesoreyeram
reviewed
Nov 7, 2024
| q.metrics.CollectDuration(SourcePlugin, StatusError, time.Since(start).Seconds()) | ||
| // We default to plugin error source | ||
| errSource := status.SourcePlugin | ||
| if backend.IsDownstreamHTTPError(err) || isProcessingDownstreamError(err) { |
There was a problem hiding this comment.
nit. does sqlds uses http transport/http based error codes?
There was a problem hiding this comment.
Yes, there are sometimes some context canceled/timeout error which are all covered in IsDownstreamHTTPError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/data-sources/issues/161
Follows up on grafana/grafana-plugin-sdk-go#1134
This PR fixes error source for errors coming from
getFramesfunction from sdk. It specifically checks for exported errors that we consider downstream fromdatapackage insdkand http downstream errors.