Skip to content

feat(push-to-gar-docker): enable docker mirror for buildx on self-hosted runners #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricky-undeadcoders
Copy link
Contributor

Update the push-to-gar-docker to utilize Grafana's internal docker mirror for self-hosted runners.

Key change:

  • actions/push-to-gar-docker/action.yaml: Added a conditional expression to set the buildkitd-config parameter to /etc/buildkitd.toml when the runner is self-hosted, and an empty string otherwise. This improves compatibility with self-hosted environments.

This requires https://github.com/grafana/deployment_tools/pull/269388 to be merged first.
Part of https://github.com/grafana/deployment_tools/issues/269366

@ricky-undeadcoders ricky-undeadcoders requested a review from a team as a code owner May 28, 2025 00:56
@iainlane
Copy link
Member

From the docs, it seems that the default path is /etc/buildkit/buildkitd.toml. If we use that path in the internal PR you referenced, would there be any client-side config needed?

@ricky-undeadcoders
Copy link
Contributor Author

ricky-undeadcoders commented May 28, 2025

From the docs, it seems that the default path is /etc/buildkit/buildkitd.toml. If we use that path in the internal PR you referenced, would there be any client-side config needed?

Interesting, I don't know, but I'll test. I was referencing these docs which suggest creating the config at /etc/buildkitd.toml.

I tested this and it did not work.

@ricky-undeadcoders ricky-undeadcoders added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 77d2ce5 May 28, 2025
22 checks passed
@ricky-undeadcoders ricky-undeadcoders deleted the rwhitaker/use-grafana-docker-mirror-push-to-gar branch May 28, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants