Fix browser.newPageInContext bug
#5322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug when
newPageInContextis called without aBrowserContext. Instead of panicking, we now try to use the default browser context if there isn't a current BC, and return an error (as before) if the requested browser ID and the BCs don't match. So, we preserve the current behavior and turn panics into errors.This fix doesn't solve the underlying race condition issue, though. The next step could be to avoid race conditions between
BrowserContext.CloseandBrowserContext.NewPage(added #5328).Why?
When
newPageInContextis called without aBrowserContext, we attempt to log with a missingBrowserContext.id, resulting in nil pointer exceptions:Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.