Skip to content

(fix) Added handling for format specifiers in console #4839 #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChandanChainani
Copy link

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

#4839

@ChandanChainani ChandanChainani requested a review from a team as a code owner July 15, 2025 06:04
@ChandanChainani ChandanChainani requested review from mstoykov and oleiade and removed request for a team July 15, 2025 06:04
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

@ChandanChainani ChandanChainani marked this pull request as draft July 15, 2025 06:08
@ChandanChainani ChandanChainani force-pushed the fix/4839/not_taking_options_params_into_account branch from cd381c7 to 38e9950 Compare July 15, 2025 06:15
@ChandanChainani ChandanChainani marked this pull request as ready for review July 15, 2025 06:15
@oleiade
Copy link
Contributor

oleiade commented Jul 15, 2025

Hi @ChandanChainani 👋🏻

Thanks for your contribution 🙇🏻

Before we can proceed with reviewing this, the PR needs some tests. Please add a test suite that covers the use-cases involved by the use-cases this introduces.

Also note that console is a Web API, and while the current implementation (I think) is not strictly complying with the specification, taking inspiration in the web platform test suite for this operation might be a good (yet not mandatory; until we decide to/proceed with making console specification-compliant) idea and starting point.

@ankur22 ankur22 added the awaiting user waiting for user to respond label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user waiting for user to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants