Skip to content

Binary provisioning/enable to all users #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pablochacin
Copy link
Contributor

What?

Do not check for users to be authenticated and also enable for local runs.

Why?

We want to enable binary provisioning to all users, not only cloud users.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@pablochacin pablochacin marked this pull request as ready for review July 21, 2025 11:54
@pablochacin pablochacin requested a review from a team as a code owner July 21, 2025 11:54
@pablochacin pablochacin requested review from ankur22 and codebien and removed request for a team July 21, 2025 11:54
codebien
codebien previously approved these changes Jul 22, 2025
ankur22
ankur22 previously approved these changes Jul 22, 2025
Base automatically changed from binary-provisioning/integrate-root-cmd to master July 25, 2025 12:28
@mstoykov mstoykov dismissed stale reviews from ankur22 and codebien July 25, 2025 12:28

The base branch was changed.

@pablochacin pablochacin added this to the v1.2.0 milestone Jul 25, 2025
@pablochacin pablochacin changed the base branch from master to binary-provisioning/integrate-root-cmd July 25, 2025 15:26
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin force-pushed the binary-provisioning/enable-to-all-users branch from 00af9c1 to 337ddaf Compare July 25, 2025 15:33
@pablochacin pablochacin changed the base branch from binary-provisioning/integrate-root-cmd to master July 25, 2025 15:33
@pablochacin pablochacin requested a review from ankur22 July 29, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants