Add getByTitle in the browser module

[ankur22]

What?

This adds a convenience method on page to be able to select on elements with the title attribute.

Why?

This is part of the story of adding getBy*, which makes working with selectors a little easier. We used to have to work with the page.locator API providing either a CSS selector or a XPath selector if we wanted to get the element by the title attribute on an element:

<div title="Information box">This is some information</div>

const l = page.locator('div[title="Information box"]'); // CSS
const l = page.locator('//div[@title="Information box"]'); // XPath

Now we can use:

const l = page.getByTitle('Information box');

Working with getBy* in general is an industry standard in the frontend testing world.

Checklist

• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests for my changes.
• I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

• I have added the correct milestone and labels to the PR.
• I have updated the release notes: link
• I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
• I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

#4793, #4248

[oleiade]

This is awesome!!

[codebien]

@ankur22 I don't see any concurrency primitive. Is this API synchronous?

[codebien]

Out of curiosity, is there a specific reason why we use static instead of the idiomatic testdata folder?

[ankur22]

No idea, it's been like that from the beginning as far as I can tell. Are there any advantages to working with testData over static?

[codebien]

From go help:

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".

AFAIK, this means static folder might be included in the built binary.

[ankur22]

I will add this to the catch all issue to explore once the getBy* PRs are all merged in 👍

[codebien]

Suggested change

	assert.NoError(t, err)
	require.NoError(t, err)

[ankur22]

Is this to force the test to stop if the assert fails?

[codebien]

It is, I don't see the reason to continue running tests if they fail in a place where we don't expect.

[ankur22]

I will review all the asserts and make sure they are require where needed in the new tests. I have added an action point in the catch all issue to work on after all the getBy* APIs have been merged in.

[ankur22]

@ankur22 I don't see any concurrency primitive. Is this API synchronous?

That's correct, it is a synchronous method. When we call page.waitForTitle it builds a locator object and returns it to the caller. This is done without performing any long running IO (e.g. CDP requests to chromium) and is a very quick process.

However, when we call a method on the locator object (e.g. l.click()) that is when it performs the IO ops against chromium to perform the action. These methods are asynchronous.

[codebien]

LGTM 👍

The base branch was changed.