Binary provisioning/use loadsource #4811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
changed the base branch from
master
to
binary-provisioning/integrate-root-cmd
8 tasks
pablochacin
force-pushed
the
binary-provisioning/use-loadsource
branch
from
e6edf2e to
9066d48
Compare
pablochacin
requested review from
oleiade and
codebien
and removed request for
a team
codebien
requested changes
Jun 17, 2025
internal/cmd/launcher.go
Outdated
| @@ -277,37 +276,37 @@ func extractToken(gs *state.GlobalState) (string, error) { | |||
| // Presently, only the k6 input script or archive (if any) is passed to k6deps for scanning. | |||
| // TODO: if k6 receives the input from stdin, it is not used for scanning because we don't know | |||
| // if it is a script or an archive | |||
| func analyze(gs *state.GlobalState, args []string) (k6deps.Dependencies, error) { | |||
| func analyze(gs *state.GlobalState, _ *cobra.Command, args []string) (k6deps.Dependencies, error) { | |||
There was a problem hiding this comment.
Suggested change
| func analyze(gs *state.GlobalState, _ *cobra.Command, args []string) (k6deps.Dependencies, error) { | |
| func analyze(gs *state.GlobalState, args []string) (k6deps.Dependencies, error) { |
I don't like the fact we are passing Cobra primitives around. Is it really required to have this dependency? Can we break it in Go/k6 primitives and more scoped for the function?
There was a problem hiding this comment.
I'm not sure what the problem is with using Cobra types, as we are within the execution of a Cobra command. Can you elaborate on what problems you see?
And, I'm not sure what you mean by "break it in Go/k6 primitives". Create abstractions around Cobra?
|
👀 |
codebien
reviewed
Jun 17, 2025
internal/cmd/launcher.go
Outdated
Comment on lines
124
to
125
| // is we are here, it is possible that the analyze function read the stdin to analyse it | ||
| // and restored the content into gs.Stdin, so we pass it to the command |
There was a problem hiding this comment.
This comment needs a re-arrangement.
There was a problem hiding this comment.
Not sure what you refer to, but the initial "is" should be "if".
8 tasks
oleiade
reviewed
Jul 22, 2025
| } | ||
|
|
||
| if strings.HasSuffix(scriptname, ".tar") { | ||
| dopts.Archive.Name = scriptname | ||
| if strings.HasSuffix(sourceRootPath, ".tar") { |
There was a problem hiding this comment.
To facilitate maintenance, I suggest creating a constant for the tar file extension. This could be done in a separate PR though 🙇🏻
codebien
reviewed
Jul 22, 2025
oleiade
previously approved these changes
Jul 23, 2025
Base automatically changed from
binary-provisioning/integrate-root-cmd
to
master
July 25, 2025 12:28
mstoykov
dismissed stale reviews from oleiade and codebien
The base branch was changed.
pablochacin
changed the base branch from
master
to
binary-provisioning/integrate-root-cmd
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
binary-provisioning/use-loadsource
branch
from
e6e0018 to
0758402
Compare
pablochacin
changed the base branch from
binary-provisioning/integrate-root-cmd
to
master
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the loadsource function for dependency analysis
Why?
Presently, binary provisioning uses its own logic for loading the input for dependency analysis. This logic has some shortcomings like not handling input for stdin or limiting the processing of scripts with specific extensions.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Depens on #4801
Closes #4727
Closes #4696