"#4751 - fix for incorrect fail and pass count in summary report" #4752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodrkumars
requested review from
inancgumus and
the-it
and removed request for
a team
|
|
|
Replied in issue #4751, and asked for clarifications 🙇🏻 In the meantime, I will mark this PR as blocked, as I don't think the code it modifies is strictly related to the reported issue. The issue is about wrong numbers reported regarding the cc @joanlopez |
joanlopez
reviewed
May 15, 2025
Comment on lines
-297
to
+298
| summaryGroup.Checks.Metrics.Fail.Values["passes"] = totalChecks - successChecks | ||
| summaryGroup.Checks.Metrics.Fail.Values["fails"] = successChecks | ||
| summaryGroup.Checks.Metrics.Fail.Values["passes"] = successChecks | ||
| summaryGroup.Checks.Metrics.Fail.Values["fails"] = totalChecks - successChecks |
There was a problem hiding this comment.
Please, note that these lines:
- First and foremost, refer to checks metrics, not browser metrics, as reported in the issue Incorrect http request pass and fail count in summary report file. #4751
- Second, and despite I know it can be confusing,
"passes"and"fails"there are the identifiers used for values of*metrics.RateSink, and as you can see, it refers to:summaryGroup.Checks.Metrics.Fail. So, "passes" really correspond to: "how many times checks failed" (note the difference withsummaryGroup.Checks.Metrics.Success.
|
Closing, because as I mentioned in #4752 (comment), it looks like a confusion, rather than a real bug. Thanks anyway @vinodrkumars for your willingness to contribute, any other contribution will be more than welcome! 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix for incorrect fail and pass count in summary report
Why?
Bug#4751
Incorrect fail and pass count in summary report
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)