[tempo-distributed] Add OTEL gRPC support for the Tempo gateway #3678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas De Gendt <jonas.degendt@mylighthouse.com>
jdegendt
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
Signed-off-by: Jonas De Gendt <jonas.degendt@mylighthouse.com>
Signed-off-by: Jonas De Gendt <jonas.degendt@mylighthouse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to address this issue from a while back: #3218
Most of the credit to @Dipu18 who's had #3261 open for a while but never addressed @joe-elliott's comments. I took his NGINX config and wrapped it and the gRPC ports in a flag that's in the values, per Joe's request to do the ports in a cleaner way.
An alternative to having the flag be
.Values.gateway.enableGrpc, we could also change it simply enable upon the global values that the distributor also uses to open up the port on its end, being.Values.traces.jaeger.grpc.enabled.Let me know if there's anything else that needs to be done on my end.