[wip]: Add i18n support for the basic panel plugin #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
sunker
moved this from 📬 Triage
to 🧑💻 In development
in Plugins Platform / Grafana Community
sunker
force-pushed
the
panel-plugin-i18n
branch
2 times, most recently
from
eebe9dc to
131e537
Compare
sunker
force-pushed
the
panel-plugin-i18n
branch
from
4204c80 to
63491f7
Compare
|
grafana/i18n@12.2.0 is out the door 👍 |
hugohaggmark
approved these changes
Sep 25, 2025
| }, | ||
| "dependencies": { | ||
| "grafanaDependency": ">=10.4.0", | ||
| "grafanaDependency": ">=11.4.8", |
There was a problem hiding this comment.
Silly question but doesn't 11.0.0 work?
Suggested change
| "grafanaDependency": ">=11.4.8", | |
| "grafanaDependency": ">=11.0.0", |
| "@emotion/css": "11.10.6", | ||
| "@grafana/data": "^12.1.0", | ||
| "@grafana/i18n": "^12.1.0", | ||
| "@grafana/i18n": "12.2.0-17630182352", |
There was a problem hiding this comment.
There is a 12.2.0 version out now 👍
github-project-automation
bot
moved this from 🧑💻 In development
to 🔬 In review
in Plugins Platform / Grafana Community
academo
requested changes
Oct 13, 2025
github-project-automation
bot
moved this from 🔬 In review
to 🧑💻 In development
in Plugins Platform / Grafana Community
sunker
added a commit
to grafana/plugin-tools
that referenced
this pull request
Oct 17, 2025
Implements complete i18n setup automation: - Updates docker-compose.yaml with localizationForPlugins feature toggle - Updates plugin.json with languages array and grafanaDependency >= 12.1.0 - Creates locale folders and translation files for selected locales - Adds @grafana/i18n dependency to package.json - Adds i18next-cli dev dependency and i18n-extract script - Creates i18next.config.ts with proper extraction configuration - Updates eslint.config.mjs with i18n linting rules - Adds i18n imports to module.ts/tsx automatically - Idempotent: safely runs multiple times without breaking - Comprehensive test suite with 8 passing tests covering: * Idempotency verification * Single and multiple locale support * Skipping when already configured * Handling existing feature toggles * Support for both .ts and .tsx modules * Version-aware dependency updates * Edge cases (missing scripts, etc.) This automates all manual steps shown in grafana/grafana-plugin-examples#588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces i18n support for the
basic-panelplugin with Swedish (supported in Grafana 11 and later) and Spanish translations.At the moment, the implementation relies on pre-release versions of
grafana/plugin-e2eandgrafana/i18n, but the changes are still ready for review. A proper release ofplugin-e2ewill follow and this PR will be updated accordingly.@hugohaggmark I guess we should hold off on merging and releasing this until
grafana/i18n@12.2.0is out the door?