E2E: Use grafana selectors instead of getByText #380
+356
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
kevinwcyu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306
We migrated prom selectors to data test id here grafana/grafana#106564 so we can change this back to use the getByGFSelector util
Had to add a condition for grafana versions cause I failed to migrate the selectors properly (I should have added another field in
packages/grafana-e2e-selectors/src/selectors/components.tsin the above PR), we can remove it once we stop supporting 11