Bugfix: Update grafana/aws-sdk-go to add externalId to assume role auth #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
kevinwcyu and
njvrzm
and removed request for
a team
kevinwcyu
approved these changes
May 19, 2025
|
Not necessary anymore since the package has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sdk to fix a bug with external id in sigv4. More here
If you'd like to test, you can
AWS datasources Prometheus instanceurl from 1passwordassume_role_amp_prometheusin raintank account and you can find the external Id in that definitionThis will assume role in raintank that has permissions to access data in raintank account by your user in external dev account