Chore: Improve performance by using storage api #342
+57
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient and improve query handling
itsmylife
reviewed
Jun 16, 2025
itsmylife
reviewed
Jun 16, 2025
pkg/bigquery/driver/rows.go
Outdated
Comment on lines
33
to
34
| // This is called after a query run from SQLDS but we don't want to close the connection here | ||
| return nil |
There was a problem hiding this comment.
If we are not closing the connection here, where are we closing it?
There was a problem hiding this comment.
+1. Also can we add info on why don't we want to close it here.
There was a problem hiding this comment.
Added more info there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way how we retrive the response from BQ. The default behavior used http in the client with a 10mb limit. So in order to get a 100mb response it had to do the roundtrip 10x times, that is costly. In this PR I enabled the storage API that uses grpc under the hood with a 128mb response limit by default.
How to test:
Use the data source from the plugin-provisioning repository and run the following query
Without this PR the query execution takes 1m with the changes it takes 8s.
Fixes #341