Improve health check by returning errors properly #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,23 +81,19 @@ export class BigQueryDatasource extends DataSourceWithBackend<BigQueryQueryNG, B | |||
| async testDatasource() { | |||
| const health = await this.callHealthCheck(); | |||
| if (health.status?.toLowerCase() === 'error') { | |||
| return { status: 'error', message: health.message, details: health.details }; | |||
There was a problem hiding this comment.
Aren't we loosing details: health.details here? Can't we do
Promise.reject({
status: 'error',
message: health.message,
details: health.details,
err: new Error(health.message)
})
| } | ||
|
|
||
| const client = await getApiClient(this.id); | ||
| try { | ||
| await client.getProjects(); | ||
| } catch (err: any) { | ||
| return { |
|
Thanks @ivanahuckova, I changed the code so now the details are provided as well. This is the way how we do in grafana/grafana https://github.com/grafana/grafana/blob/main/packages/grafana-runtime/src/utils/DataSourceWithBackend.ts#L385 |
ivanahuckova
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.