-
Notifications
You must be signed in to change notification settings - Fork 61
docs: add query docs for github #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd keep this all on one page. Users can click the link to jump to the section(s) that apply to their use case. l I'm looking for heading and title guidance in our Writer's Toolkit and don't see any. I'll refer you to Google's style guide (which is what ours is based on) for heading and title guidance. https://developers.google.com/style/headings#markdown I did a quick review, I'll do a more comprehensive one in the next day or two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe you also want to wait for a review from the docs team
@@ -12,7 +12,7 @@ labels: | |||
- oss | |||
- enterprise | |||
- cloud | |||
weight: 200 | |||
weight: 300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to this weight change the following weights should also be updated:
/variables-and-macros > variables.md
from 201 to 301,
/variables-and-macros > macros.md
from 202 to 302
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird in a way... I thought the weights were relative within a directory? i.e. this will only affect the order from within the variables and macros subfolder.
I can make the change for consistency, but imo these should be 100 and 200 respectively
| updated_at | When the item was last updated: YYYY-MM-DD HH:MM:SS | | ||
| closed_at | When the item was closed, if applicable: YYYY-MM-DD HH:MM:SS | | ||
| (custom fields) | Any custom defined fields will also be returned alongside their values | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move both notes to the bottom?
{{< admonition type="note" >}} | |
This query returns a maximum of 200 results. | |
{{< /admonition >}} | |
{{< admonition type="note" >}} | |
GitHub Projects allow for customization of default fields and custom fields to be added, | |
therefore the response can vary significantly between projects." | |
{{< /admonition >}} |
personally think its looks cleaner/easier to read with this change, WDYT?


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the note on the customization only applies for the response where a project number is specified, whereas the query limit is generic...
How about moving query limit notes consistently higher up - i.e. before query options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If using headings like ##### Sample queries you should skip a line. You can also just use Sample queries instead of using a heading.
https://grafana.com/docs/writers-toolkit/write/markdown-guide/#heading-donts
@lwandz13 thank you for the review 🙏 I've stuck with h5 purely as it gives the ability to grab a direct link to share |
This PR adds detailed documentation for the query types supported by the github data source
It introduces a summary table of all available types as well as details on:
TODO:
Notes for reviewers:
packages.go
- I was unable to query this successfullyvalue
column for vulnerabilities, again took a guess.Potential follow ups: