Skip to content

Chore: Some import order changes #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025

Conversation

itsmylife
Copy link
Contributor

@itsmylife itsmylife commented Apr 30, 2025

This is a test PR to test workflows.
No functionality change has introduced.

Context about the workflow changes: https://raintank-corp.slack.com/archives/C08PXG0H960/p1746021293905729?thread_ts=1745941388.694869&cid=C08PXG0H960

@itsmylife itsmylife requested a review from a team as a code owner April 30, 2025 12:37
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@itsmylife itsmylife requested a review from jdbaldry as a code owner April 30, 2025 13:45
@@ -1,5 +1,6 @@
name: Update `make docs` procedure
permissions: {}
permissions:
contents: read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow creates branches and opens PRs so may need contents: write and pull-requests: write

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaldry Could you review and approve the PR? Looks like CI is waiting for your approval

    Waiting on code owner review from jdbaldry.

Copy link

@guicaulada guicaulada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes look good! pkg changes seem to be just minor import reordering and formatting changes.

@itsmylife itsmylife merged commit f892668 into main Apr 30, 2025
15 checks passed
@itsmylife itsmylife deleted the ismail/small-fixes-to-test-workflows branch April 30, 2025 15:08
@github-project-automation github-project-automation bot moved this to Complete in OSS Big Tent Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants