Skip to content

Allow the datasource to be specified with managed alerting #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dmyerscough
Copy link
Contributor

This change allows you to specify the datasource to check for managed alerts. With Grafana Cloud the default looks to be grafanacloud-prom. Whereas, with Grafana OSS its grafana.

I tested these changes on the Grafana Cloud and a private installation of Grafana.

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • I have performed a self-review of this patch

@dmyerscough dmyerscough requested a review from amotl as a code owner March 4, 2025 00:40
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (9847667) to head (7e6d114).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          27       27           
  Lines        1817     1818    +1     
=======================================
+ Hits         1678     1679    +1     
  Misses        139      139           
Flag Coverage Δ
unittests 92.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl
Copy link
Contributor

amotl commented Mar 4, 2025

Thank you very much, Damian. 💯

@amotl amotl merged commit 39bfa3c into grafana-toolbox:main Mar 4, 2025
6 checks passed
@amotl
Copy link
Contributor

amotl commented Mar 4, 2025

Hi again. We just released version 4.3.2, including your improvement. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants