Skip to content

Support querying all Data source-managed alerts #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmyerscough
Copy link
Contributor

@dmyerscough dmyerscough commented Feb 8, 2025

Description

This change enables querying all Data source-managed, I tested this with Grafana Playground

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • I have performed a self-review of this patch

@dmyerscough dmyerscough requested a review from amotl as a code owner February 8, 2025 06:58
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (d554ba5) to head (298cd2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   92.33%   92.34%           
=======================================
  Files          27       27           
  Lines        1814     1816    +2     
=======================================
+ Hits         1675     1677    +2     
  Misses        139      139           
Flag Coverage Δ
unittests 92.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmyerscough dmyerscough force-pushed the grafana-datasource-managed-alerts branch from a4b1072 to 298cd2e Compare February 8, 2025 07:00
Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@amotl amotl merged commit 290a091 into grafana-toolbox:main Feb 8, 2025
6 checks passed
@amotl
Copy link
Contributor

amotl commented Feb 8, 2025

Your improvements have been included into grafana-client 4.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants